From fab5072ce1396484b9caa7320da4dc3c98070adc Mon Sep 17 00:00:00 2001 From: MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz> Date: Thu, 12 Mar 2026 13:23:50 +0100 Subject: [PATCH] ci: Remove vulture --- ci/lint/01_install.sh | 3 +-- test/lint/README.md | 1 - test/lint/lint-python-dead-code.py | 41 ------------------------------ 3 files changed, 1 insertion(+), 44 deletions(-) delete mode 100755 test/lint/lint-python-dead-code.py diff --git a/ci/lint/01_install.sh b/ci/lint/01_install.sh index 4cf695b817b..9372df5a9bd 100755 --- a/ci/lint/01_install.sh +++ b/ci/lint/01_install.sh @@ -44,8 +44,7 @@ ${CI_RETRY_EXE} pip3 install \ lief==0.16.6 \ mypy==1.19.1 \ pyzmq==27.1.0 \ - ruff==0.15.5 \ - vulture==2.14 + ruff==0.15.5 SHELLCHECK_VERSION=v0.11.0 curl -sL "https://github.com/koalaman/shellcheck/releases/download/${SHELLCHECK_VERSION}/shellcheck-${SHELLCHECK_VERSION}.linux.x86_64.tar.xz" | \ diff --git a/test/lint/README.md b/test/lint/README.md index e98522a7e60..08703ab8efb 100644 --- a/test/lint/README.md +++ b/test/lint/README.md @@ -52,7 +52,6 @@ or `--help`: | [`lint-python.py`](/test/lint/lint-python.py) | [lief](https://github.com/lief-project/LIEF) | [`lint-python.py`](/test/lint/lint-python.py) | [mypy](https://github.com/python/mypy) | [`lint-python.py`](/test/lint/lint-python.py) | [pyzmq](https://github.com/zeromq/pyzmq) -| [`lint-python-dead-code.py`](/test/lint/lint-python-dead-code.py) | [vulture](https://github.com/jendrikseipp/vulture) | [`lint-shell.py`](/test/lint/lint-shell.py) | [ShellCheck](https://github.com/koalaman/shellcheck) | `py_lint` | [ruff](https://github.com/astral-sh/ruff) | markdown link check | [mlc](https://github.com/becheran/mlc) diff --git a/test/lint/lint-python-dead-code.py b/test/lint/lint-python-dead-code.py deleted file mode 100755 index cd6471e2ab7..00000000000 --- a/test/lint/lint-python-dead-code.py +++ /dev/null @@ -1,41 +0,0 @@ -#!/usr/bin/env python3 -# -# Copyright (c) 2022-present The Bitcoin Core developers -# Distributed under the MIT software license, see the accompanying -# file COPYING or http://www.opensource.org/licenses/mit-license.php. - -""" -Find dead Python code. -""" - -from subprocess import check_output, STDOUT, CalledProcessError - -FILES_ARGS = ['git', 'ls-files', '--', '*.py'] - - -def check_vulture_install(): - try: - check_output(["vulture", "--version"]) - except FileNotFoundError: - print("Skipping Python dead code linting since vulture is not installed. Install by running \"pip3 install vulture\"") - exit(0) - - -def main(): - check_vulture_install() - - files = check_output(FILES_ARGS, text=True).splitlines() - # --min-confidence 100 will only report code that is guaranteed to be unused within the analyzed files. - # Any value below 100 introduces the risk of false positives, which would create an unacceptable maintenance burden. - vulture_args = ['vulture', '--min-confidence=100'] + files - - try: - check_output(vulture_args, stderr=STDOUT, text=True) - except CalledProcessError as e: - print(e.output, end="") - print("Python dead code detection found some issues") - exit(1) - - -if __name__ == "__main__": - main()