From bb1aff7ed7e4bd6618dfe75b5faa9956c3adead4 Mon Sep 17 00:00:00 2001 From: Hodlinator <172445034+hodlinator@users.noreply.github.com> Date: Mon, 26 Jan 2026 11:04:53 +0100 Subject: [PATCH] move-only(qa): Move wallet creation check down to others Makes the functions broken out from run_test() in the next commit more cohesive. --- test/functional/wallet_multiwallet.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/test/functional/wallet_multiwallet.py b/test/functional/wallet_multiwallet.py index 86d2737d74e..cd3ada3a519 100755 --- a/test/functional/wallet_multiwallet.py +++ b/test/functional/wallet_multiwallet.py @@ -153,10 +153,6 @@ class MultiWalletTest(BitcoinTestFramework): assert_equal(set(node.listwallets()), set(wallet_names)) - # should raise rpc error if wallet path can't be created - err_code = -4 - assert_raises_rpc_error(err_code, "filesystem error:" if platform.system() != 'Windows' else "create_directories:", node.createwallet, "w8/bad") - # check that all requested wallets were created self.stop_node(0) for wallet_name in wallet_names: @@ -304,6 +300,10 @@ class MultiWalletTest(BitcoinTestFramework): self.log.info("Test dynamic wallet creation.") + # should raise rpc error if wallet path can't be created + err_code = -4 + assert_raises_rpc_error(err_code, "filesystem error:" if platform.system() != 'Windows' else "create_directories:", node.createwallet, "w8/bad") + # Fail to create a wallet if it already exists. path = wallet_dir(node, "w2") assert_raises_rpc_error(-4, "Failed to create database path '{}'. Database already exists.".format(path), node.createwallet, 'w2')