diff --git a/test/functional/test_framework/test_node.py b/test/functional/test_framework/test_node.py index e978c1e3790..a7d29e8df00 100755 --- a/test/functional/test_framework/test_node.py +++ b/test/functional/test_framework/test_node.py @@ -208,10 +208,10 @@ class TestNode(): def __getattr__(self, name): """Dispatches any unrecognised messages to the RPC connection or a CLI instance.""" if self.use_cli: - return getattr(RPCOverloadWrapper(self.cli), name) + return getattr(self.cli, name) else: assert self.rpc_connected and self.rpc is not None, self._node_msg("Error: no RPC connection") - return getattr(RPCOverloadWrapper(self.rpc), name) + return getattr(self.rpc, name) def start(self, extra_args=None, *, cwd=None, stdout=None, stderr=None, env=None, **kwargs): """Start the node.""" @@ -373,11 +373,11 @@ class TestNode(): def get_wallet_rpc(self, wallet_name): if self.use_cli: - return RPCOverloadWrapper(self.cli("-rpcwallet={}".format(wallet_name))) + return self.cli("-rpcwallet={}".format(wallet_name)) else: assert self.rpc_connected and self.rpc, self._node_msg("RPC not connected") wallet_path = "wallet/{}".format(urllib.parse.quote(wallet_name)) - return RPCOverloadWrapper(self.rpc / wallet_path) + return self.rpc / wallet_path def version_is_at_least(self, ver): return self.version is None or self.version >= ver @@ -922,10 +922,3 @@ class TestNodeCLI(): return json.loads(cli_stdout, parse_float=decimal.Decimal) except (json.JSONDecodeError, decimal.InvalidOperation): return cli_stdout.rstrip("\n") - -class RPCOverloadWrapper(): - def __init__(self, rpc): - self.rpc = rpc - - def __getattr__(self, name): - return getattr(self.rpc, name) diff --git a/test/functional/wallet_migration.py b/test/functional/wallet_migration.py index fe348d4d73f..700d801891c 100755 --- a/test/functional/wallet_migration.py +++ b/test/functional/wallet_migration.py @@ -726,7 +726,7 @@ class WalletMigrationTest(BitcoinTestFramework): send_to_script(script=script_sh_pkh, amount=2) # Import script and check balance - wallet.rpc.importaddress(address=script_pkh.hex(), label="raw_spk", rescan=True, p2sh=True) + wallet.importaddress(address=script_pkh.hex(), label="raw_spk", rescan=True, p2sh=True) assert_equal(wallet.getbalances()['watchonly']['trusted'], 2) # Craft wsh(pkh(key)) and send coins to it @@ -735,7 +735,7 @@ class WalletMigrationTest(BitcoinTestFramework): send_to_script(script=script_wsh_pkh, amount=3) # Import script and check balance - wallet.rpc.importaddress(address=script_wsh_pkh.hex(), label="raw_spk2", rescan=True, p2sh=False) + wallet.importaddress(address=script_wsh_pkh.hex(), label="raw_spk2", rescan=True, p2sh=False) assert_equal(wallet.getbalances()['watchonly']['trusted'], 5) # Import sh(pkh()) script, by using importaddress(), with the p2sh flag enabled. @@ -751,7 +751,7 @@ class WalletMigrationTest(BitcoinTestFramework): # Note: 'importaddress()' will add two scripts, a valid one sh(pkh()) and an invalid one 'sh(sh(pkh()))'. # Both of them will be stored with the same addressbook label. And only the latter one should # be discarded during migration. The first one must be migrated. - wallet.rpc.importaddress(address=script_sh_pkh.hex(), label=label_sh_pkh, rescan=False, p2sh=True) + wallet.importaddress(address=script_sh_pkh.hex(), label=label_sh_pkh, rescan=False, p2sh=True) # Migrate wallet and re-check balance info_migration, wallet = self.migrate_and_get_rpc("raw_p2sh")