From 9f2b338bc01832e335f652e23f1318ee44cdd63c Mon Sep 17 00:00:00 2001 From: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com> Date: Fri, 23 Jan 2026 13:41:00 +0000 Subject: [PATCH] subprocess: Fix `-Wunused-private-field` for `Popen` class on Windows When compiling with clang-cl on Windows, `src/util/subprocess.h` emits `-Wunused-private-field` warnings about unused private fields in the `Popen` class. --- src/util/subprocess.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/util/subprocess.h b/src/util/subprocess.h index e90c165205e..e261215cc50 100644 --- a/src/util/subprocess.h +++ b/src/util/subprocess.h @@ -1024,6 +1024,9 @@ private: #ifdef __USING_WINDOWS__ HANDLE process_handle_; std::future cleanup_future_; +#else + // Pid of the child process + int child_pid_ = -1; #endif std::string exe_name_; @@ -1034,9 +1037,6 @@ private: std::vector vargs_; std::vector cargv_; - // Pid of the child process - int child_pid_ = -1; - int retcode_ = -1; };