From 93cb8f03807dcd3297b7fe18b6c901a8d2a01596 Mon Sep 17 00:00:00 2001
From: stratospher <44024636+stratospher@users.noreply.github.com>
Date: Mon, 14 Aug 2023 17:01:07 +0530
Subject: [PATCH] refactor: add missing headers for BIP324 ciphersuite

---
 src/bip324.cpp                  | 5 +++++
 src/bip324.h                    | 1 +
 src/crypto/chacha20poly1305.cpp | 2 --
 src/crypto/chacha20poly1305.h   | 1 -
 src/test/bip324_tests.cpp       | 4 +++-
 src/test/fuzz/bip324.cpp        | 1 -
 6 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/src/bip324.cpp b/src/bip324.cpp
index 7ed99e5585d..314e756829f 100644
--- a/src/bip324.cpp
+++ b/src/bip324.cpp
@@ -8,14 +8,19 @@
 #include <crypto/chacha20.h>
 #include <crypto/chacha20poly1305.h>
 #include <crypto/hkdf_sha256_32.h>
+#include <key.h>
+#include <pubkey.h>
 #include <random.h>
 #include <span.h>
 #include <support/cleanse.h>
+#include <uint256.h>
 
 #include <algorithm>
 #include <assert.h>
 #include <cstdint>
 #include <cstddef>
+#include <iterator>
+#include <string>
 
 BIP324Cipher::BIP324Cipher() noexcept
 {
diff --git a/src/bip324.h b/src/bip324.h
index ecab299af5e..0238c479c08 100644
--- a/src/bip324.h
+++ b/src/bip324.h
@@ -5,6 +5,7 @@
 #ifndef BITCOIN_BIP324_H
 #define BITCOIN_BIP324_H
 
+#include <array>
 #include <cstddef>
 #include <optional>
 
diff --git a/src/crypto/chacha20poly1305.cpp b/src/crypto/chacha20poly1305.cpp
index 2636ebe2b2a..26161641bb3 100644
--- a/src/crypto/chacha20poly1305.cpp
+++ b/src/crypto/chacha20poly1305.cpp
@@ -11,9 +11,7 @@
 #include <support/cleanse.h>
 
 #include <assert.h>
-#include <cstdint>
 #include <cstddef>
-#include <iterator>
 
 AEADChaCha20Poly1305::AEADChaCha20Poly1305(Span<const std::byte> key) noexcept : m_chacha20(UCharCast(key.data()))
 {
diff --git a/src/crypto/chacha20poly1305.h b/src/crypto/chacha20poly1305.h
index dc8fb1cc13f..a847c258ef1 100644
--- a/src/crypto/chacha20poly1305.h
+++ b/src/crypto/chacha20poly1305.h
@@ -6,7 +6,6 @@
 #define BITCOIN_CRYPTO_CHACHA20POLY1305_H
 
 #include <cstddef>
-#include <cstdlib>
 #include <stdint.h>
 
 #include <crypto/chacha20.h>
diff --git a/src/test/bip324_tests.cpp b/src/test/bip324_tests.cpp
index 0bc22496e3f..04472611ec6 100644
--- a/src/test/bip324_tests.cpp
+++ b/src/test/bip324_tests.cpp
@@ -6,13 +6,15 @@
 #include <chainparams.h>
 #include <key.h>
 #include <pubkey.h>
+#include <span.h>
 #include <test/util/random.h>
 #include <test/util/setup_common.h>
 #include <util/strencodings.h>
 
 #include <array>
-#include <vector>
 #include <cstddef>
+#include <cstdint>
+#include <vector>
 
 #include <boost/test/unit_test.hpp>
 
diff --git a/src/test/fuzz/bip324.cpp b/src/test/fuzz/bip324.cpp
index 8282261c52a..98ac10e364f 100644
--- a/src/test/fuzz/bip324.cpp
+++ b/src/test/fuzz/bip324.cpp
@@ -11,7 +11,6 @@
 #include <test/util/xoroshiro128plusplus.h>
 
 #include <cstdint>
-#include <tuple>
 #include <vector>
 
 namespace {