From e71c4df1685131f5ab48aac6ccb07ac944e91e9f Mon Sep 17 00:00:00 2001 From: ANtutov Date: Wed, 10 Dec 2025 11:48:50 +0000 Subject: [PATCH] refactor: replace manual promise with SyncWithValidationInterfaceQueue --- src/node/transaction.cpp | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/src/node/transaction.cpp b/src/node/transaction.cpp index f5bd0efe744..05450299e59 100644 --- a/src/node/transaction.cpp +++ b/src/node/transaction.cpp @@ -15,8 +15,6 @@ #include #include -#include - namespace node { static TransactionError HandleATMPError(const TxValidationState& state, std::string& err_string_out) { @@ -45,7 +43,6 @@ TransactionError BroadcastTransaction(NodeContext& node, assert(node.mempool); assert(node.peerman); - std::promise promise; Txid txid = tx->GetHash(); Wtxid wtxid = tx->GetWitnessHash(); bool callback_set = false; @@ -115,9 +112,6 @@ TransactionError BroadcastTransaction(NodeContext& node, // with a transaction to/from their wallet, immediately call some // wallet RPC, and get a stale result because callbacks have not // yet been processed. - node.validation_signals->CallFunctionInValidationInterfaceQueue([&promise] { - promise.set_value(); - }); callback_set = true; } } @@ -126,7 +120,7 @@ TransactionError BroadcastTransaction(NodeContext& node, if (callback_set) { // Wait until Validation Interface clients have been notified of the // transaction entering the mempool. - promise.get_future().wait(); + node.validation_signals->SyncWithValidationInterfaceQueue(); } switch (broadcast_method) {