From 997e7b4d7cf7c4622938798423447375383184c0 Mon Sep 17 00:00:00 2001
From: sedited <seb.kung@gmail.com>
Date: Wed, 7 Jan 2026 20:51:28 +0100
Subject: [PATCH] init: Fix non-zero code on interrupt

An interrupt does not create a failure exit code during normal
operation. This should also be the case when interrupt is triggered
during initialization. However a failure exit code is currently returned
if an interrupt occurs during init. Fix this by making `AppInitMain` return
true instead of false, which further up the call stack sets the
`EXIT_FAILURE` code. Also add a check for the interrupt condition during
GUI startup.
---
 src/init.cpp       |  4 +--
 src/qt/bitcoin.cpp | 77 +++++++++++++++++++++++-----------------------
 2 files changed, 41 insertions(+), 40 deletions(-)

diff --git a/src/init.cpp b/src/init.cpp
index f2af858eb46..d435a216547 100644
--- a/src/init.cpp
+++ b/src/init.cpp
@@ -1830,7 +1830,7 @@ bool AppInitMain(NodeContext& node, interfaces::BlockAndHeaderTipInfo* tip_info)
     // requested to kill the GUI during the last operation. If so, exit.
     if (ShutdownRequested(node)) {
         LogInfo("Shutdown requested. Exiting.");
-        return false;
+        return true;
     }
 
     ChainstateManager& chainman = *Assert(node.chainman);
@@ -2006,7 +2006,7 @@ bool AppInitMain(NodeContext& node, interfaces::BlockAndHeaderTipInfo* tip_info)
     }
 
     if (ShutdownRequested(node)) {
-        return false;
+        return true;
     }
 
     // ********************************************************* Step 12: start node
diff --git a/src/qt/bitcoin.cpp b/src/qt/bitcoin.cpp
index 54e1747c898..92c815fe70e 100644
--- a/src/qt/bitcoin.cpp
+++ b/src/qt/bitcoin.cpp
@@ -380,53 +380,54 @@ void BitcoinApplication::initializeResult(bool success, interfaces::BlockAndHead
 {
     qDebug() << __func__ << ": Initialization result: " << success;
 
-    if (success) {
-        delete m_splash;
-        m_splash = nullptr;
+    if (!success || m_node->shutdownRequested()) {
+        requestShutdown();
+        return;
+    }
 
-        // Log this only after AppInitMain finishes, as then logging setup is guaranteed complete
-        qInfo() << "Platform customization:" << platformStyle->getName();
-        clientModel = new ClientModel(node(), optionsModel);
-        window->setClientModel(clientModel, &tip_info);
+    delete m_splash;
+    m_splash = nullptr;
 
-        // If '-min' option passed, start window minimized (iconified) or minimized to tray
-        bool start_minimized = gArgs.GetBoolArg("-min", false);
+    // Log this only after AppInitMain finishes, as then logging setup is guaranteed complete
+    qInfo() << "Platform customization:" << platformStyle->getName();
+    clientModel = new ClientModel(node(), optionsModel);
+    window->setClientModel(clientModel, &tip_info);
+
+    // If '-min' option passed, start window minimized (iconified) or minimized to tray
+    bool start_minimized = gArgs.GetBoolArg("-min", false);
 #ifdef ENABLE_WALLET
-        if (WalletModel::isWalletEnabled()) {
-            m_wallet_controller = new WalletController(*clientModel, platformStyle, this);
-            window->setWalletController(m_wallet_controller, /*show_loading_minimized=*/start_minimized);
-            if (paymentServer) {
-                paymentServer->setOptionsModel(optionsModel);
-            }
+    if (WalletModel::isWalletEnabled()) {
+        m_wallet_controller = new WalletController(*clientModel, platformStyle, this);
+        window->setWalletController(m_wallet_controller, /*show_loading_minimized=*/start_minimized);
+        if (paymentServer) {
+            paymentServer->setOptionsModel(optionsModel);
         }
+    }
 #endif // ENABLE_WALLET
 
-        // Show or minimize window
-        if (!start_minimized) {
-            window->show();
-        } else if (clientModel->getOptionsModel()->getMinimizeToTray() && window->hasTrayIcon()) {
-            // do nothing as the window is managed by the tray icon
-        } else {
-            window->showMinimized();
-        }
-        Q_EMIT windowShown(window);
+    // Show or minimize window
+    if (!start_minimized) {
+        window->show();
+    } else if (clientModel->getOptionsModel()->getMinimizeToTray() && window->hasTrayIcon()) {
+        // do nothing as the window is managed by the tray icon
+    } else {
+        window->showMinimized();
+    }
+    Q_EMIT windowShown(window);
 
 #ifdef ENABLE_WALLET
-        // Now that initialization/startup is done, process any command-line
-        // bitcoin: URIs or payment requests:
-        if (paymentServer) {
-            connect(paymentServer, &PaymentServer::receivedPaymentRequest, window, &BitcoinGUI::handlePaymentRequest);
-            connect(window, &BitcoinGUI::receivedURI, paymentServer, &PaymentServer::handleURIOrFile);
-            connect(paymentServer, &PaymentServer::message, [this](const QString& title, const QString& message, unsigned int style) {
-                window->message(title, message, style);
-            });
-            QTimer::singleShot(100ms, paymentServer, &PaymentServer::uiReady);
-        }
-#endif
-        pollShutdownTimer->start(SHUTDOWN_POLLING_DELAY);
-    } else {
-        requestShutdown();
+    // Now that initialization/startup is done, process any command-line
+    // bitcoin: URIs or payment requests:
+    if (paymentServer) {
+        connect(paymentServer, &PaymentServer::receivedPaymentRequest, window, &BitcoinGUI::handlePaymentRequest);
+        connect(window, &BitcoinGUI::receivedURI, paymentServer, &PaymentServer::handleURIOrFile);
+        connect(paymentServer, &PaymentServer::message, [this](const QString& title, const QString& message, unsigned int style) {
+            window->message(title, message, style);
+        });
+        QTimer::singleShot(100ms, paymentServer, &PaymentServer::uiReady);
     }
+#endif
+    pollShutdownTimer->start(SHUTDOWN_POLLING_DELAY);
 }
 
 void BitcoinApplication::handleRunawayException(const QString &message)