cryptogera/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-01-31 10:41:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(miniscript): Destroy nodes one full subs-vector at a time

Browse Source
This commit is contained in:
Hodlinator 2025-11-21 16:24:22 +01:00
parent 50cab8570e
commit 198bbaee49
No known key found for this signature in database
1 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/script/miniscript.h
View File

@ -552,14 +552,15 @@ public:
// Destroy the subexpressions iteratively after moving out their
// subexpressions to avoid a stack-overflow due to recursive calls to
// the subs' destructors.
while (!subs.empty()) {
auto node = std::move(subs.back());
subs.pop_back();
while (!node.subs.empty()) {
subs.push_back(std::move(node.subs.back()));
node.subs.pop_back();
std::vector<std::vector<Node>> queue;
queue.push_back(std::move(subs));
do {
auto flattening{std::move(queue.back())};
queue.pop_back();
for (Node& n : flattening) {
if (!n.subs.empty()) queue.push_back(std::move(n.subs));
}
}
} while (!queue.empty());
}
// NOLINTEND(misc-no-recursion)