beachcoin

History

John Newbery 6d07c62322 Return correct error codes in bumpfee().

The bumpfee() RPC was returning misleading or incorrect error codes
(for example RPC_INVALID_ADDRESS_OR_KEY when the transaction was not
BIP125 replacable). This commit fixes those error codes:

- RPC_INVALID_ADDRESS_OR_KEY if an invalid address was provided:
    - Invalid change address given
- RPC_INVALID_PARAMETER if a single (non-address/key) parameter is incorrect
    - confTarget and totalFee options should not both be set.
    - Invalid confTarget
    - Insufficient totalFee (cannot be less than required fee)
- RPC_WALLET_ERROR for any other error
    - Transaction has descendants in the wallet
    - Transaction has descendants in the mempool
    - Transaction has been mined, or is conflicted with a mined transaction
    - Transaction is not BIP 125 replaceable
    - Transaction has already been bumped
    - Transaction contains inputs that don't belong to the wallet
    - Transaction has multiple change outputs
    - Transaction does not have a change output
    - Fee is higher than maxTxFee
    - New fee rate is less than the minimum fee rate
    - Change output is too small.

This commit also updates the test cases to explicitly test the error code.

2017-03-07 16:45:09 -05:00

bench

Merge #9548 : Remove min reasonable fee

2017-03-07 19:49:00 +01:00

compat

Increment MIT Licence copyright header year on files modified in 2016

2016-12-31 11:01:21 -07:00

config

…

consensus

[trivial] Fix typos in comments

2017-01-27 21:22:35 +01:00

crypto

Avoid unaligned access in crypto i/o

2017-01-12 11:52:45 -08:00

leveldb

Merge in LevelDB 1.19 changes

2016-12-01 16:14:45 -08:00

obj

…

obj-test

…

policy

Merge #9548 : Remove min reasonable fee

2017-03-07 19:49:00 +01:00

primitives

Merge #9602 : Remove coin age priority and free transactions - implementation

2017-03-07 19:30:23 +01:00

Merge #9602 : Remove coin age priority and free transactions - implementation

2017-03-07 19:30:23 +01:00

rpc

Merge #9602 : Remove coin age priority and free transactions - implementation

2017-03-07 19:30:23 +01:00

script

Merge #8808 : Do not shadow variables (gcc set)

2017-03-03 15:48:53 +01:00

secp256k1

Update libsecp256k1 to master

2016-12-12 11:08:47 -08:00

support

Merge #8808 : Do not shadow variables (gcc set)

2017-03-03 15:48:53 +01:00

test

Merge #9548 : Remove min reasonable fee

2017-03-07 19:49:00 +01:00

univalue

Merge commit '2ca7faab4205822b06dc2ab2bbda0a9a70fce7e0' into HEAD

2016-09-30 19:58:11 +02:00

wallet

Return correct error codes in bumpfee().

2017-03-07 16:45:09 -05:00

zmq

Increment MIT Licence copyright header year on files modified in 2016

2016-12-31 11:01:21 -07:00

.clang-format

[doc] Remove unused clang format dev script

2017-01-28 16:57:08 +01:00

addrdb.cpp

Increment MIT Licence copyright header year on files modified in 2016

2016-12-31 11:01:21 -07:00

addrdb.h

Increment MIT Licence copyright header year on files modified in 2016

2016-12-31 11:01:21 -07:00

addrman.cpp

Use z = std::max(x - y, 0); instead of z = x - y; if (z < 0) z = 0;

2017-02-07 15:46:38 +01:00

addrman.h

Increment MIT Licence copyright header year on files modified in 2016

2016-12-31 11:01:21 -07:00

amount.cpp

Increment MIT Licence copyright header year on files modified in 2016

2016-12-31 11:01:21 -07:00

amount.h

Increment MIT Licence copyright header year on files modified in 2016

2016-12-31 11:01:21 -07:00

arith_uint256.cpp

Merge #8808 : Do not shadow variables (gcc set)

2017-03-03 15:48:53 +01:00

arith_uint256.h

Increment MIT Licence copyright header year on files modified in 2016

2016-12-31 11:01:21 -07:00

base58.cpp

Increment MIT Licence copyright header year on files modified in 2016

2016-12-31 11:01:21 -07:00

base58.h

[trivial] Fix typos in comments

2017-01-27 21:22:35 +01:00

bitcoin-cli-res.rc

…

bitcoin-cli.cpp

Docs: add details to -rpcclienttimeout doc

2017-03-02 04:42:37 -08:00

bitcoin-tx-res.rc

…

bitcoin-tx.cpp

Merge #8883 : Add all standard TXO types to bitcoin-tx

2017-01-12 12:24:35 +01:00

bitcoind-res.rc

…

bitcoind.cpp

use EXIT_ codes instead of magic numbers

2017-02-21 17:17:24 +09:00

blockencodings.cpp

Clarify comment about mempool/extra conflicts

2017-01-16 22:58:06 -05:00

blockencodings.h

[trivial] Fix typos in comments

2017-01-27 21:22:35 +01:00

bloom.cpp

Refactor: Remove using namespace <xxx> from src/*.cpp.

2017-01-27 18:13:20 +09:00

bloom.h

Increment MIT Licence copyright header year on files modified in 2016

2016-12-31 11:01:21 -07:00

chain.cpp

Refactor: Remove using namespace <xxx> from src/*.cpp.

2017-01-27 18:13:20 +09:00

chain.h

Merge #9908 : Define 7200 second timestamp window constant

2017-03-06 10:02:05 +01:00

chainparams.cpp

Add seed.btc.petertodd.org to mainnet DNS seeds

2017-02-19 16:11:54 -05:00

chainparams.h

Shorten variable names and switch to tx/s

2017-01-11 08:21:37 -08:00

chainparamsbase.cpp

…

chainparamsbase.h

…

chainparamsseeds.h

Pre-0.14.0 hardcoded seeds update

2017-02-10 11:04:34 +01:00

checkpoints.cpp

[MOVEONLY] Move progress estimation out of checkpoints

2017-01-04 13:18:49 -08:00

checkpoints.h

[MOVEONLY] Move progress estimation out of checkpoints

2017-01-04 13:18:49 -08:00

checkqueue.h

…

clientversion.cpp

Increment MIT Licence copyright header year on files modified in 2016

2016-12-31 11:01:21 -07:00

clientversion.h

build: bump version to 0.14.99

2017-02-17 17:27:18 +01:00

coins.cpp

[cleanup] Remove coin age priority completely.

2017-03-03 16:50:20 -05:00

coins.h

[cleanup] Remove coin age priority completely.

2017-03-03 16:50:20 -05:00

compat.h

Increment MIT Licence copyright header year on files modified in 2016

2016-12-31 11:01:21 -07:00

compressor.cpp

…

compressor.h

Increment MIT Licence copyright header year on files modified in 2016

2016-12-31 11:01:21 -07:00

core_io.h

Increment MIT Licence copyright header year on files modified in 2016

2016-12-31 11:01:21 -07:00

core_memusage.h

Increment MIT Licence copyright header year on files modified in 2016

2016-12-31 11:01:21 -07:00

core_read.cpp

Fail in DecodeHexTx if there is extra data at the end

2017-02-02 17:32:27 -05:00

core_write.cpp

Refactor: Remove using namespace <xxx> from src/*.cpp.

2017-01-27 18:13:20 +09:00

cuckoocache.h

[trivial] Fix typos in comments

2017-01-27 21:22:35 +01:00

dbwrapper.cpp

Increment MIT Licence copyright header year on files modified in 2016

2016-12-31 11:01:21 -07:00

dbwrapper.h

Merge #9353 : Add data() method to CDataStream (and use it)

2017-01-09 08:47:47 -08:00

hash.cpp

Remove redundant semicolons

2017-01-14 21:45:32 +01:00

hash.h

Avoid VLA in hash.h

2017-02-17 15:28:28 -08:00

httprpc.cpp

Make KEY_SIZE a compile-time constant

2017-02-17 11:42:22 -08:00

httprpc.h

…

httpserver.cpp

Access WorkQueue::running only within the cs lock.

2017-02-03 13:50:17 -05:00

httpserver.h

Increment MIT Licence copyright header year on files modified in 2016

2016-12-31 11:01:21 -07:00

indirectmap.h

prepend license statement to indirectmap

2016-07-27 16:27:07 -07:00

init.cpp

Merge #9602 : Remove coin age priority and free transactions - implementation

2017-03-07 19:30:23 +01:00

init.h

Increment MIT Licence copyright header year on files modified in 2016

2016-12-31 11:01:21 -07:00

key.cpp

Increment MIT Licence copyright header year on files modified in 2016

2016-12-31 11:01:21 -07:00

key.h

Increment MIT Licence copyright header year on files modified in 2016

2016-12-31 11:01:21 -07:00

keystore.cpp

Increment MIT Licence copyright header year on files modified in 2016

2016-12-31 11:01:21 -07:00

keystore.h

…

limitedmap.h

Increment MIT Licence copyright header year on files modified in 2016

2016-12-31 11:01:21 -07:00

Makefile.am

build: add --enable-werror option

2017-02-23 01:06:04 -05:00

Makefile.bench.include

Add Basic CheckQueue Benchmark

2017-01-09 14:07:02 -05:00

Makefile.leveldb.include

Merge #8826 : Do not include env_win.cc on non-Windows systems

2016-09-29 17:27:28 +02:00

Makefile.qt.include

Merge #9513 : build: fix qt distdir builds (retry)

2017-01-11 13:45:28 +01:00

Makefile.qttest.include

Uses built-in byte swap if available (Apple) and if bswap_XX is undefined.

2016-12-17 12:27:00 +09:00

Makefile.test.include

util: Specific GetOSRandom for Linux/FreeBSD/OpenBSD

2017-02-21 20:57:34 +01:00

memusage.h

Increment MIT Licence copyright header year on files modified in 2016

2016-12-31 11:01:21 -07:00

merkleblock.cpp

Refactor: Remove using namespace <xxx> from src/*.cpp.

2017-01-27 18:13:20 +09:00

merkleblock.h

Increment MIT Licence copyright header year on files modified in 2016

2016-12-31 11:01:21 -07:00

miner.cpp

Merge #9602 : Remove coin age priority and free transactions - implementation

2017-03-07 19:30:23 +01:00

miner.h

Merge #9602 : Remove coin age priority and free transactions - implementation

2017-03-07 19:30:23 +01:00

net_processing.cpp

No longer allow "free" transactions

2017-03-03 16:50:19 -05:00

net_processing.h

Net: pass interruptMsgProc as const where possible

2017-01-31 23:45:47 +01:00

net.cpp

CScheduler boost->std::function, use millisecs for times, not secs

2017-03-06 18:33:50 -05:00

net.h

Move CNode::addrLocal access behind locked accessors

2017-02-10 11:32:41 -05:00

netaddress.cpp

Increment MIT Licence copyright header year on files modified in 2016

2016-12-31 11:01:21 -07:00

netaddress.h

[trivial] Fix typos in comments

2017-01-27 21:22:35 +01:00

netbase.cpp

netbase: Do not print an error on connection timeouts through proxy

2017-02-09 08:53:22 +01:00

netbase.h

Merge #9289 : net: drop boost::thread_group

2017-01-04 12:21:53 +01:00

netmessagemaker.h

Net: Make CNetMsgMaker more const

2017-01-31 23:29:28 +01:00

noui.cpp

Increment MIT Licence copyright header year on files modified in 2016

2016-12-31 11:01:21 -07:00

noui.h

…

pow.cpp

Increment MIT Licence copyright header year on files modified in 2016

2016-12-31 11:01:21 -07:00

pow.h

Increment MIT Licence copyright header year on files modified in 2016

2016-12-31 11:01:21 -07:00

prevector.h

prevector: assert successful allocation

2017-02-27 14:52:15 -05:00

protocol.cpp

Increment MIT Licence copyright header year on files modified in 2016

2016-12-31 11:01:21 -07:00

protocol.h

Increment MIT Licence copyright header year on files modified in 2016

2016-12-31 11:01:21 -07:00

pubkey.cpp

2016-12-31 11:01:21 -07:00

pubkey.h

2016-12-31 11:01:21 -07:00

random.cpp

random: Add fallback if getrandom syscall not available

2017-02-22 08:51:26 +01:00

random.h

sanity: Move OS random to sanity check function

2017-02-22 08:02:50 +01:00

rest.cpp

Refactor: Remove using namespace <xxx> from src/*.cpp.

2017-01-27 18:13:20 +09:00

reverselock.h

2016-12-31 11:01:21 -07:00

scheduler.cpp

CScheduler boost->std::function, use millisecs for times, not secs

2017-03-06 18:33:50 -05:00

scheduler.h

CScheduler boost->std::function, use millisecs for times, not secs

2017-03-06 18:33:50 -05:00

serialize.h

2016-12-31 11:01:21 -07:00

streams.h

Merge #8808 : Do not shadow variables (gcc set)

2017-03-03 15:48:53 +01:00

sync.cpp

Further-enforce lockordering by enforcing directly after TRY_LOCKs

2017-02-07 14:15:28 -05:00

sync.h

Break addnode out from the outbound connection limits.

2017-01-05 19:02:09 +00:00

threadinterrupt.cpp

net: add CThreadInterrupt and InterruptibleSleep

2017-01-03 17:53:09 -05:00

threadinterrupt.h

net: add CThreadInterrupt and InterruptibleSleep

2017-01-03 17:53:09 -05:00

threadsafety.h

…

timedata.cpp

Refactor: Remove using namespace <xxx> from src/*.cpp.

2017-01-27 18:13:20 +09:00

timedata.h

Merge #8808 : Do not shadow variables (gcc set)

2017-03-03 15:48:53 +01:00

tinyformat.h

util: Update tinyformat

2016-06-27 18:17:27 +02:00

torcontrol.cpp

[trivial] Fix typos in comments

2017-01-27 21:22:35 +01:00

torcontrol.h

…

txdb.cpp

Refactor: Remove using namespace <xxx> from src/*.cpp.

2017-01-27 18:13:20 +09:00

txdb.h

2016-12-31 11:01:21 -07:00

txmempool.cpp

Merge #9548 : Remove min reasonable fee

2017-03-07 19:49:00 +01:00

txmempool.h

Merge #9548 : Remove min reasonable fee

2017-03-07 19:49:00 +01:00

ui_interface.cpp

[wallet] Add high transaction fee warnings

2016-09-26 01:11:27 +02:00

ui_interface.h

2016-12-31 11:01:21 -07:00

uint256.cpp

uint256: replace sprintf with HexStr and reverse-iterator

2017-02-27 10:02:45 +01:00

uint256.h

2016-12-31 11:01:21 -07:00

undo.h

2016-12-31 11:01:21 -07:00

util.cpp

Fix for issue #9775 . Added check for open() returning a NULL pointer.

2017-02-20 23:53:18 +05:30

util.h

Merge #9417 : Do not evaluate hidden LogPrint arguments

2017-01-05 10:49:00 +01:00

utilmoneystr.cpp

…

utilmoneystr.h

…

utilstrencodings.cpp

Wallet: Sanitise -wallet parameter

2017-02-27 20:45:18 +00:00

utilstrencodings.h

Wallet: Sanitise -wallet parameter

2017-02-27 20:45:18 +00:00

utiltime.cpp

[trivial] Fix typos in comments

2017-01-27 21:22:35 +01:00

utiltime.h

[trivial] Fix recently introduced typos in comments

2017-02-14 20:19:40 +01:00

validation.cpp

Merge #9548 : Remove min reasonable fee

2017-03-07 19:49:00 +01:00

validation.h

No longer allow "free" transactions

2017-03-03 16:50:19 -05:00

validationinterface.cpp

Add a CValidationInterface::NewPoWValidBlock callback

2017-01-05 10:32:07 -05:00

validationinterface.h

[trivial] Fix recently introduced typos in comments

2017-02-14 20:19:40 +01:00

version.h

2016-12-31 11:01:21 -07:00

versionbits.cpp

RPC: augment getblockchaininfo bip9_softforks data

2016-10-19 09:08:39 -04:00

versionbits.h

RPC: augment getblockchaininfo bip9_softforks data

2016-10-19 09:08:39 -04:00

warnings.cpp

Move GetWarnings() into its own file.

2016-12-03 07:17:34 +00:00

warnings.h

Move GetWarnings() into its own file.

2016-12-03 07:17:34 +00:00